Adding azdoPrRepoName as metadata in FluxCD alert #74
+134
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eedorenko
requested changes
Aug 21, 2024
| logging.debug(f'azdoPrRepoName: {repo_n}') | ||
| if repo_n != '': | ||
| self._gitops_operator.callback_url = self._git_repository.set_git_repository(repo_n) | ||
| self._cicd_orchestrator.set_git_repository(repo_n) |
There was a problem hiding this comment.
The GitOps connector instance is shared across threads. It is very possible that another thread, initiated by an alert configured for the different application/repo, will override these self settings. So the message from thread 1 will go to the repo from thread 2.
There was a problem hiding this comment.
Besides forwarding the alerts to AZDO, GitOps connector detects abandoned/rejected PRs to the GitOps repo and notifies the agentless waiting task to fail, so the whole promotional flow gets failed. This logic is implemented on top of having a single repo.
IMO, if we want to support multiple applications, we have the options:
- Have an instance of GitOps Connector per application
- Enhance the GitOps Connector to be configured with multiple repos (e.g. in config maps) and like you suggested, reference these repos in the alert definition
|
Thanks for the review, so I'm closing the Pull Request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a metadata in the alert definition of the gitops-connector to be able to identify the name of the repo corresponding to the PR. This modification allowed me to support my scenario where I have a manifest repo per application.
spec:
eventMetadata:
azdoPrRepoName: WebApp1
I should mention that I don't know the Python language and I went with the logic of the existing code so don't judge my code too harshly.